Add more parser tests

src/Language/helpers.php

@@ -156,11 +156,11 @@ function blockStringValue(string $rawString): string
         }
     }
 
-    while ($lineCount > 0 && isBlank($lines[0])) {
+    while (count($lines) > 0 && isBlank($lines[0])) {
         array_shift($lines);
     }
 
-    while ($lineCount > 0 && isBlank($lines[$lineCount - 1])) {
+    while (($lineCount = count($lines)) > 0 && isBlank($lines[$lineCount - 1])) {
         array_pop($lines);
     }
 

src/Type/Definition/Behavior/ValueTrait.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Digia\GraphQL\Type\Definition\Behavior;
+
+trait ValueTrait
+{
+
+    /**
+     * @var mixed|null
+     */
+    protected $value;
+
+    /**
+     * @return mixed|null
+     */
+    public function getValue()
+    {
+        return $this->value;
+    }
+}

src/Type/Definition/EnumValue.php

@@ -2,13 +2,13 @@
 
 namespace Digia\GraphQL\Type\Definition;
 
-use Digia\GraphQL\Behavior\ValueTrait;
 use Digia\GraphQL\ConfigObject;
 use Digia\GraphQL\Language\AST\Node\EnumValueDefinitionNode;
 use Digia\GraphQL\Language\AST\Node\NodeTrait;
 use Digia\GraphQL\Type\Definition\Behavior\DeprecationTrait;
 use Digia\GraphQL\Type\Definition\Behavior\DescriptionTrait;
 use Digia\GraphQL\Type\Definition\Behavior\NameTrait;
+use Digia\GraphQL\Type\Definition\Behavior\ValueTrait;
 
 /**
  * Class EnumValue

src/Type/Schema/Schema.php

@@ -217,14 +217,10 @@ protected function buildTypeMap(): void
         $typeMap = [];
 
         // First by deeply visiting all initial types.
-        $typeMap = array_reduce($initialTypes, function ($map, $type) {
-            return typeMapReducer($map, $type);
-        }, $typeMap);
+        $typeMap = array_reduce($initialTypes, 'Digia\GraphQL\Type\Schema\typeMapReducer', $typeMap);
 
         // Then by deeply visiting all directive types.
-        $typeMap = array_reduce($this->directives, function ($map, $directive) {
-            return typeMapDirectiveReducer($map, $directive);
-        }, $typeMap);
+        $typeMap = array_reduce($this->directives, 'Digia\GraphQL\Type\Schema\typeMapDirectiveReducer', $typeMap);
 
         // Storing the resulting map for reference by the schema.
         $this->_typeMap = $typeMap;
@@ -330,7 +326,7 @@ protected function setAssumeValid(bool $assumeValid): Schema
  */
 function typeMapReducer(array $map, ?TypeInterface $type): array
 {
-    if (!$type) {
+    if (null === $type) {
         return $map;
     }
 
@@ -357,15 +353,11 @@ function typeMapReducer(array $map, ?TypeInterface $type): array
     $reducedMap = $map;
 
     if ($type instanceof UnionType) {
-        $reducedMap = array_reduce($type->getTypes(), function ($map, $type) {
-            return typeMapReducer($map, $type);
-        }, $reducedMap);
+        $reducedMap = array_reduce($type->getTypes(), 'Digia\GraphQL\Type\Schema\typeMapReducer', $reducedMap);
     }
 
     if ($type instanceof ObjectType) {
-        $reducedMap = array_reduce($type->getInterfaces(), function ($map, $type) {
-            return typeMapReducer($map, $type);
-        }, $reducedMap);
+        $reducedMap = array_reduce($type->getInterfaces(), 'Digia\GraphQL\Type\Schema\typeMapReducer', $reducedMap);
     }
 
     if ($type instanceof ObjectType || $type instanceof InterfaceType) {
@@ -375,9 +367,7 @@ function typeMapReducer(array $map, ?TypeInterface $type): array
                     return $argument->getType();
                 }, $field->getArgs());
 
-                $reducedMap = array_reduce($fieldArgTypes, function ($map, $type) {
-                    return typeMapReducer($map, $type);
-                }, $reducedMap);
+                $reducedMap = array_reduce($fieldArgTypes, 'Digia\GraphQL\Type\Schema\typeMapReducer', $reducedMap);
             }
 
             $reducedMap = typeMapReducer($reducedMap, $field->getType());

tests/Functional/Language/ParserTest.php

@@ -26,6 +26,7 @@
 use Digia\GraphQL\Language\AST\Builder\SelectionSetBuilder;
 use Digia\GraphQL\Language\AST\Builder\StringBuilder;
 use Digia\GraphQL\Language\AST\Builder\VariableBuilder;
+use Digia\GraphQL\Language\AST\Builder\VariableDefinitionBuilder;
 use Digia\GraphQL\Language\AST\Node\DocumentNode;
 use Digia\GraphQL\Language\AST\Node\NamedTypeNode;
 use Digia\GraphQL\Language\AST\Node\NullValueNode;
@@ -85,6 +86,7 @@ public function setUp()
             new SelectionSetBuilder(),
             new StringBuilder(),
             new VariableBuilder(),
+            new VariableDefinitionBuilder(),
         ];
 
         $readers = [
@@ -207,6 +209,18 @@ public function testParsesMultiByteCharacters()
 
     // TODO: Consider adding test for 'parses kitchen sink'
 
+    /**
+     * @throws \Digia\GraphQL\Error\GraphQLError
+     * @throws \Exception
+     */
+    public function testParsesKitchenSink()
+    {
+        $kitchenSink = mb_convert_encoding(file_get_contents(__DIR__ . '/kitchen-sink.graphql'), 'UTF-8');
+
+        $this->parser->parse(new Source($kitchenSink));
+        $this->addToAssertionCount(1);
+    }
+
     /**
      * @throws \Digia\GraphQL\Error\GraphQLError
      * @throws \Exception

tests/Functional/Language/kitchen-sink.graphql

@@ -0,0 +1,59 @@
+# Copyright (c) 2015-present, Facebook, Inc.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+query queryName($foo: ComplexType, $site: Site = MOBILE) {
+  whoever123is: node(id: [123, 456]) {
+    id ,
+    ... on User @defer {
+      field2 {
+        id ,
+        alias: field1(first:10, after:$foo,) @include(if: $foo) {
+          id,
+          ...frag
+        }
+      }
+    }
+    ... @skip(unless: $foo) {
+      id
+    }
+    ... {
+      id
+    }
+  }
+}
+
+mutation likeStory {
+  like(story: 123) @defer {
+    story {
+      id
+    }
+  }
+}
+
+subscription StoryLikeSubscription($input: StoryLikeSubscribeInput) {
+  storyLikeSubscribe(input: $input) {
+    story {
+      likers {
+        count
+      }
+      likeSentence {
+        text
+      }
+    }
+  }
+}
+
+fragment frag on Friend {
+  foo(size: $size, bar: $b, obj: {key: "value", block: """
+
+      block string uses \"""
+
+  """})
+}
+
+{
+  unnamed(truthy: true, falsey: false, nullish: null),
+  query
+}