Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Flatten directory structure #20

Merged
merged 2 commits into from Mar 1, 2018
Merged

Flatten directory structure #20

merged 2 commits into from Mar 1, 2018

Conversation

crisu83
Copy link
Contributor

@crisu83 crisu83 commented Feb 28, 2018

No description provided.

@crisu83 crisu83 self-assigned this Feb 28, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 150

  • 31 of 37 (83.78%) changed or added relevant lines in 9 files are covered.
  • 20 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.03%) to 86.262%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Type/scalars.php 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/Type/scalars.php 1 58.95%
src/Execution/ExecutionContext.php 1 87.5%
src/Execution/ExecutorExecutionStrategy.php 2 71.43%
src/Execution/ExecutionArguments.php 2 0.0%
src/Execution/ExecutionResult.php 3 50.0%
src/Execution/ExecutionStrategy.php 4 85.71%
src/Execution/Execution.php 7 83.33%
Totals Coverage Status
Change from base Build 134: -0.03%
Covered Lines: 1890
Relevant Lines: 2191
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 28, 2018 •
edited

Pull Request Test Coverage Report for Build 152

  • 31 of 37 (83.78%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 86.249%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Type/scalars.php 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/Type/scalars.php 1 58.95%
Totals Coverage Status
Change from base Build 134: -0.04%
Covered Lines: 1888
Relevant Lines: 2189
💛 - Coveralls

@crisu83 crisu83 mentioned this pull request Feb 28, 2018
Closed
@crisu83
Copy link
Contributor Author

crisu83 commented Mar 1, 2018 •
edited

@hungneox I didn't touch the Execution so this should be fine to merge.

@crisu83 crisu83 merged commit edaba1f into master Mar 1, 2018
@crisu83 crisu83 deleted the flatten-dirs branch March 1, 2018 09:36
@crisu83 crisu83 added this to the Version 1.0 milestone Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hungneox hungneox hungneox approved these changes

Assignees

@crisu83 crisu83

Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisu83 @coveralls @hungneox