This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Execution fragments deeper #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 214
💛 - Coveralls |
crisu83
approved these changes
Mar 5, 2018
| */ | ||
| private function getFieldNameKey(FieldNode $node) | ||
| { | ||
| return $node->getAlias() |
There was a problem hiding this comment.
We should a hasAlias method to the associated trait and use that instead.
|
|
||
| $result = $this->resolveField($parentType, | ||
| $source, | ||
| [], |
There was a problem hiding this comment.
We don't support arguments yet?
There was a problem hiding this comment.
We do support args
$inputValues = $fieldNode->getArguments() ?? [];
$args = [];
foreach ($inputValues as $value) {
if ($value instanceof ArgumentNode) {
$args[] = $value->getValue()->getValue();
} elseif ($value instanceof InputValueDefinitionNode) {
$args[] = $value->getDefaultValue()->getValue();
}
}
src/Execution/ExecutionStrategy.php
Outdated
| $fields | ||
| ); | ||
|
|
||
| $subResult = array_merge_recursive( |
There was a problem hiding this comment.
This can be a costy operation. We should add a TODO to benchmark it.
There was a problem hiding this comment.
I'm going to refactor this very soon :D
| $fields = $this->collectFields( | ||
| $parentType, | ||
| $fieldNode->getSelectionSet(), | ||
| new \ArrayObject(), |
hungneox
force-pushed
the
execution-fragments-deeper
branch
from
ce75112
to
f616829
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to improve the implementation a lot more but basically now the execution can execute multiple fragments.
It's done in a recursive way which I think not so good. I will try to do it in non-recursive way.