This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Refactor CorsServiceProvider to be compatible with Laravel #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests are failing on the CI. |
|
@hugovk the tests pass just fine, it's the CI funnel that is messed up. |
|
@crisu83 the tests most definitely don't pass, at least not according to Travis CI. |
|
@crisu83 seems the tests were already broken (no idea why), can you fix them? |
crisu83
force-pushed
the
refactor-service-provider
branch
from
dcaab35
to
2bc431e
Compare
|
Now the tests are fixed. |
Jalle19
approved these changes
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.