This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Include the node ID in MalformedNodeIdException messages #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 6, 2018 14:02
…ption Makes it much easier to deduce the actual problem from logs
hungneox
reviewed
Sep 6, 2018
src/Fields/NodeIdResolver.php
Outdated
| */ | ||
| public static function typeFromGlobalId($globalId) | ||
| public static function typeFromGlobalId($globalId): string |
There was a problem hiding this comment.
Should we type-hint for the parameter(s) also?
hungneox
reviewed
Sep 6, 2018
hungneox
approved these changes
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.