This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Update wording to match the documentation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes - remove pendingUrl which is not used anymore - use amount not quantity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly got annoyed when the wording differs from that of the official documentation because it is not imminently clear that
postOfficewill be automatically converted topostalOffice. I don't care which is linguistically better but please go with the one that's already used in the official documentation.Also there was a random
quantityfield left on the readme that's supposed to beamount.DISCLAIMER: I haven't run any tests on the changes but I'm expecting breakage.Nevermind, there's a Travis CI runner set.