chore: add types for nanobench #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change has no impact, but it should make it easier to type-check in the future. [0]: DefinitelyTyped/DefinitelyTyped#68221
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jan 19, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change primarily impacts editor tools. Similar to [another change in mapeo-core-next][1]. [0]: DefinitelyTyped/DefinitelyTyped#68221 [1]: digidem/mapeo-core-next#441
This was referenced Jan 19, 2024
Open
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jan 25, 2024
Types for nanobench were [recently added to DefinitelyTyped][0], so we can use them. The `benchmarks` directory is not currently type-checked, so this change primarily impacts editor tools. Similar to [another change in mapeo-core-next][1]. [0]: DefinitelyTyped/DefinitelyTyped#68221 [1]: digidem/mapeo-core-next#441
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types for nanobench were recently added to DefinitelyTyped, so we can use them.
The
benchmarksdirectory is not currently type-checked, so this change has no impact, but it should make it easier to type-check in the future.