chore: update bonjour-service to v1.2.1 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version integrates all of our patches except the one for the `probe` option when starting a `Service`. That version also has some trickiness around types for `start` and `stop`, which are also fixed here. I submitted these patches [upstream] but haven't heard back as of this writing. [upstream]: onlxltd/bonjour-service#48
EvanHahn
commented
Feb 12, 2024
| @@ -119,7 +119,7 @@ export class DnsSd extends TypedEmitter { | |||
| host: this.#name + '.local', | |||
| port, | |||
| type: SERVICE_NAME, | |||
| disableIpv6: this.#disableIpv6, | |||
| disableIPv6: this.#disableIpv6, | |||
There was a problem hiding this comment.
Our old patch used a slightly different name than the "real" version upstream.
There was a problem hiding this comment.
Again, I submitted these changes upstream.
achou11
approved these changes
Feb 13, 2024
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version integrates all of our patches except the one for the
probeoption when starting aService. That version also has some trickiness around types forstartandstop, which are also fixed here.I submitted these patches upstream but haven't heard back as of this writing.