fix: Only fetch download speed when opening the Updater tab.

src/main/auto-updater.js

@@ -63,7 +63,7 @@ class MapeoUpdater extends events.EventEmitter {
     return releaseSummary
   }
 
-  async _getDownloadSpeed () {
+  async getDownloadSpeed () {
     let downloadSpeed
     try {
       downloadSpeed = await networkSpeed.download()
@@ -91,15 +91,12 @@ class MapeoUpdater extends events.EventEmitter {
         return logger.info('[UPDATER] Must use an AppImage, dmg, or exe for automatic updates.')
       }
 
-      var downloadSpeed = await this._getDownloadSpeed()
-
       var args = {
         version,
         files,
         path,
         sha512,
         releaseDate,
-        downloadSpeed,
         releaseSummary: null // TODO: this._getReleaseSummary(version)
       }
 

src/main/ipc.js

@@ -57,6 +57,10 @@ module.exports = function (ipcSend) {
     ipcSend('update-status', 'update-available', updateInfo)
   })
 
+  ipcMain.handle('get-download-speed', async function (event) {
+    await updater.getDownloadSpeed()
+  })
+
   ipcMain.on('download-update', function (event) {
     updater.downloadUpdate()
   })

src/renderer/components/UpdaterView/index.js

@@ -1,12 +1,14 @@
-import React from 'react'
+import React, { useEffect, useState } from 'react'
 import { LinearProgress, Typography, makeStyles } from '@material-ui/core'
 import { defineMessages, useIntl } from 'react-intl'
 import Button from '@material-ui/core/Button'
 import FormattedDuration from 'react-intl-formatted-duration'
 import ErrorIcon from '@material-ui/icons/Error'
 import Paper from '@material-ui/core/Paper'
-import Loader from '../Loader'
 
+import Loader from '../Loader'
+import logger from '../../../logger'
+import ipc from '../../electron-ipc'
 import STATES from './states'
 export { default as STATES } from './states'
 
@@ -24,6 +26,7 @@ const m = defineMessages({
   patchUpdate: 'This update includes changes that fix critical errors. Please update as soon as possible.',
   minorUpdate: 'This update includes improvements that may change your experience.',
   majorUpdate: 'This update will make your application incompatible with earlier verions.',
+  calculatingDownloadSpeed: 'Calculating...',
   unknownDownloadSpeed: 'Unknown',
   estimatedDownloadTime: 'Estimated download time is'
 })
@@ -150,13 +153,27 @@ const DownloadProgressView = ({ cx, update, percent }) => {
 const UpdateAvailableView = ({ cx, update, setUpdate }) => {
   const { formatMessage: t } = useIntl()
 
-  const { size, downloadSpeed, major, minor, patch } = update.updateInfo
+  const [downloadSpeed, setDownloadSpeed] = useState(Infinity)
+
+  useEffect(() => {
+    ipc.getDownloadSpeed().then((downloadSpeed) => {
+      setDownloadSpeed(downloadSpeed)
+    }).catch((err) => {
+      logger.error(err)
+      // Could not get download speed
+      setDownloadSpeed(null)
+    })
+  })
+
+  const { size, major, minor, patch } = update.updateInfo
 
   const handleDownlaoadClick = setUpdate.downloadUpdate
 
-  const estimatedDownloadTime = downloadSpeed
-    ? <FormattedDuration seconds={size / downloadSpeed.bps} />
-    : t(m.unknownDownloadSpeed)
+  const estimatedDownloadTime = downloadSpeed === Infinity
+    ? t(m.calculatingDownloadSpeed)
+    : downloadSpeed === null || downloadSpeed === undefined
+      ? t(m.unknownDownloadSpeed)
+      : <FormattedDuration seconds={size / downloadSpeed.bps} />
 
   return (
     <div className={cx.searchingText}>
@@ -179,7 +196,10 @@ const UpdateAvailableView = ({ cx, update, setUpdate }) => {
           </Typography>
 
           <Typography className={cx.estimatedDownloadTime}>
-            {t(m.estimatedDownloadTime)} {estimatedDownloadTime}
+            {t(m.estimatedDownloadTime)}
+          </Typography>
+          <Typography>
+            {estimatedDownloadTime}
           </Typography>
 
           <Button
@@ -272,7 +292,7 @@ const useStyles = makeStyles(theme => ({
     marginTop: '15px'
   },
   estimatedDownloadTime: {
-    margin: '10px 0px'
+    margin: '15px 0px'
   },
   icon: {
     fontSize: 48

src/renderer/electron-ipc.js

@@ -21,6 +21,9 @@ function Api (ipcRenderer) {
     },
     quitAndInstall: function () {
       ipcRenderer.send('quit-and-install')
+    },
+    getDownloadSpeed: async function () {
+      await ipcRenderer.invoke('get-download-speed')
     }
   }
 }