Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support helperText for fields in iD and improve field display #341

Merged
merged 1 commit into from
May 8, 2020

Conversation

gmaclennan
Copy link
Member

I made some changes to our fork of iD Editor to better display preset fields in iD Editor. The changes are in digidem/iD-mapeo#12 and include:

  • Remove support for tagInfo lookups (this only worked for OSM tags, which we do not generally use, and did not work offline.
  • Use the UI space for tagInfo for displaying a new field property helperText which shows additional information to help a user answer a question / fill in the field.
  • Remove the option to collapse the "All Fields" section of the preset editor. This was unintuitive and could result in users collapsing it by mistake and not being able to find the fields to fill in.
  • Allows labels for fields to span multiple lines
  • Removes the "Unknown" defult placeholder, and just displays an empty input box if no placeholder is defined for a field.
  • Uses field.label as the label if no translation is available (previously it defaulted to field.id if no translation was defined.
  • Ensure dropdowns are attached to the input field, not to the bottom of the helper text.

@okdistribute okdistribute merged commit fdcb70e into master May 8, 2020
@okdistribute okdistribute deleted the feat/id-update branch May 8, 2020 20:15
@okdistribute okdistribute added this to Done in Tech Priorities Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants