fix: do not show download dialog when closing export menu #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Andrew! Hadn't picked this one up, good catch. CI was failing because I needed to accept a new license agreement in the Apple Developer portal. Re-running now, will merge when green. |
gmaclennan
added a commit
that referenced
this pull request
Jun 22, 2021
…c-integration * commit '8d656302ee0a3f15d953d9772c6bf95290511488': fix: do not show download dialog when closing export menu (#489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
Script and updated it if necessary.
npm install --package-lockDescription
Closing the export menu via an outside click or the esc key causes the download dialog to appear. This PR fixes the behavior so that those interactions only close the menu