Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: permission form, add two questions and answers in en #677

Merged

Conversation

RainbowGiantSquid
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations. Please submit translation changes via our Mapeo Crowdin project
  • My commits are in nice logical chunks with good commit messages
  • I have walked through the QA Manual Testing
    Script
    and updated it if necessary.
  • If my changes depend upon an update to a dependency, I have updated the package-lock.json file using npm install --package-lock
  • My changes have been tested with the mobile app.
  • My changes are ready to be shipped to users on Windows, Mac, and Linux using the production version of the application built with electron-builder.

Description

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. @RainbowGiantSquid have you tested this to ensure that it displays correctly in the app and exports in the format you would like?

@gmaclennan gmaclennan mentioned this pull request May 9, 2022
6 tasks
@gmaclennan gmaclennan merged commit f307b7a into digidem:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants