Ej/revert changes to master #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@achou do you have an idea of why these tests are failing? Is this an issue with the previous state of |
|
@gmaclennan seeing this in the logs during the publish step: 1 package(s) were not uploaded because they had problems:
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/E8F11344-8E19-4F6C-8325-A6E4F47C1A5B/32a2f111e9c0fedaa8d3ff5da14c4fc7.itmsp - Error Messages:
You must first sign the relevant contracts online. (1048)
Error: Notarization failed for '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/electron-notarize-lNiffH/Mapeo for ICCAs.zip'.
Error: You must first sign the relevant contracts online. (1048) (1048)looks like just some Apple policy changes that require your review in the developer account:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverses changes made when accidentally pushing straight to
masterbranch!Sorry for the trouble ! 馃槵