Skip to content

Commit

Permalink
chore: Fix Github CI builds by removing NDK r22 (#516)
Browse files Browse the repository at this point in the history
See #517 for explanation
An update to the Github Action virtual environment added NDK r22,
which CMake uses, ignoring $ANDROID_NDK_HOME.
Solution: Remove NDK r22 and update to latest NDK r21f
  • Loading branch information
gmaclennan committed Feb 12, 2021
1 parent 6093c3e commit 228a381
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/android.yml
Expand Up @@ -37,6 +37,9 @@ jobs:
# mv android-ndk-r${ANDROID_NDK_VERSION} $ANDROID_NDK_HOME
# ls -al $ANDROID_NDK_HOME
# cat $ANDROID_NDK_HOME/source.properties
- name: Delete newer NDK version
run: |
rm -rf $ANDROID_HOME/ndk/22*
- name: Download Android Emulator Image
run: |
sdkmanager --update | grep -v = || true
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Expand Up @@ -10,7 +10,7 @@ buildscript {
supportLibVersion = "29.0.0"
// Kotlin is needed by Detox testing framework
kotlinVersion = "1.3.50"
ndkVersion = "21.3.6528147"
ndkVersion = "21.4.7075529"
}
repositories {
google()
Expand Down
4 changes: 3 additions & 1 deletion bitrise.yml
Expand Up @@ -283,11 +283,13 @@ workflows:
# debug log
set -x
ANDROID_NDK_VERSION='21.3.6528147'
ANDROID_NDK_VERSION='21.4.7075529'
echo '### User Sources for Android SDK Manager' > $HOME/.android/repositories.cfg
yes | sdkmanager --licenses
sdkmanager --update | grep -v = || true
# Remove NDK r22 (can cause builds to fail)
rm -rf $ANDROID_HOME/ndk/22*
sdkmanager --install "ndk;${ANDROID_NDK_VERSION}"
echo "Updated to latest SDK:"
Expand Down

0 comments on commit 228a381

Please sign in to comment.