Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.0 #358

Merged
merged 118 commits into from
Jul 22, 2020
Merged

Release v5.0.0 #358

merged 118 commits into from
Jul 22, 2020

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Mar 27, 2020

This PR is to prepare for release v5.0.0 (previously v2.1.0, but bumping the version number to bring in-line with Mapeo Desktop). This is testing a new release process, where "Release Candidates" for testing will be shared in this PR. When it has passed QA testing then this will be merged with the deploy branch and released to Google Play, Github Releases, etc.

See the draft changelog for changes since our last public release (v2.0.0-beta.5)

Note that previously we released "betas" publicly. From now on we no longer use "beta" and "alpha" terms.

APKs for testing

  • QA v5.0.0-RC.844: You can install this alongside your existing Mapeo App and test out new features without affecting your existing data. Look for the red logo.
  • ⚠️v5.0.0-RC.844 APK: This will replace your existing Mapeo installation and you will not be able to downgrade - if it does not work you will need to wait for a fix.

gmaclennan and others added 30 commits November 29, 2019 21:22
…and bug fixes)

Squashed commits:
[2cdd3e6] chore: Cleanup unused vars (+7 squashed commits)
[2599762] chore: Fix gradlew script (was throwing warning)
[dd60087] chore: Update deps
[c41f02d] fix: Update react-native-v8 for RN 0.61
[556422c] Update to latest unimodules
[737c490] remove redundant patch (issue was fixed in RN61)
[8cf62f0] Bump react-native-fs to latest
[37a7e1e] Update to RN 0.61.5
…n on GPS and Sync screens)

Simplify the navigation structure to remove nested stacks and use the built-in react-navigation headers.
Change the way navigation is blocked for user confirmation after creating or editing an observation.
Uses back arrow (not X close icon) on GPS and Sync modals, since this is the Android default.
* New translations en.json (Burmese)

* New translations en.json (Khmer)

* New translations en.json (Lao)

* New translations en.json (Thai)

* New translations en.json (Vietnamese)

* New translations en.json (Hindi)

* New translations en.json (Indonesian)

* New translations en.json (Malay)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Indonesian)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Nepali)

* New translations en.json (Spanish)

* New translations en.json (French)

* New translations en.json (Spanish)

* New translations en.json (Portuguese, Brazilian)

* New translations en.json (Burmese)

* New translations en.json (Khmer)

* New translations en.json (Lao)

* New translations en.json (Thai)

* New translations en.json (Vietnamese)

* New translations en.json (Hindi)

* New translations en.json (Indonesian)

* New translations en.json (Malay)

* New translations en.json (Nepali)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Burmese)

* New translations en.json (French)

* New translations en.json (Hindi)

* New translations en.json (Indonesian)

* New translations en.json (Khmer)

* New translations en.json (Lao)

* New translations en.json (Malay)

* New translations en.json (Nepali)

* New translations en.json (Portuguese, Brazilian)

* New translations en.json (Spanish)

* New translations en.json (Thai)

* New translations en.json (Vietnamese)
…anguage) (#302)

* Abstract persisted state to a custom hook

* Add context for user-selected locale

* Change to list-based settings screen

* Add language settings screen

* move settings icon onto observationList screen

* Extract translatable strings

* Only extract `en` messages - crowdin will deal with the rest

* Make language screen scrollable

* Sort languages by english name

* Include English name in language list

* add dense list settings for formatting settings selectone field

* fix: add react-native-screens
fix: add package-lock.json files for front and backend
Almost all phones use Arm chips, so this reduces the size by about 50% with little impact. Users of Intel devices (some rare phones from about 2015 and some Chromebooks that run Android apps) will need to use the Intel or Universal APKs.

* Do not include support x86 in the main release APK

* Add intel-only build for x86 phones

Very few Android devices, apart from Chromebooks, are x86.
This would mainly be for the 2015 ASUS Zenphone in case users want to use it.
The PlayStore release will continue to be cross-platform, but splitting the APK into two releases reduces the APK size by about 40%.

* Add universal build

* More sensible naming of output apks

* Only create universal and debug build for QA

* remove unused dep

This was only used for yarn with patch-package, and we don't use yarn.

* Fix for running `npm ci` on CI

* Add bitrise.yml to repo

* Remove exposed AWS key (exposed key de-activated)

* Change keystore passwords and move to env variables

* Setup bitrise.yml to run from repo

* Sign QA builds with a separate key

* Adjust apk naming

* Setup beta and release workflows

* rename workflows
Bumps [acorn](https://github.com/acornjs/acorn) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@7.1.0...7.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
@aliya-ryan
Copy link
Member

aliya-ryan commented Jul 9, 2020

Test results
Samsung Galaxy Grand Prime+
Android v 6.0.1

Full notes in script: https://www.notion.so/digidem/9-July-2020-mapeo-v5-0-0-RC-810-QA-debug-apk-0474cf2d693d4a4cb4da2c7fa7c89c1d

I just did minimal testing of most essential parts - according to shortened script created by @jencastrodoesstuff for Tom R. to test.

I found no errors I would consider to be blocking (but did not do full test)

I tested sync with my mac, using v5.3.0-beta.2
I could not test sync with another phone as gave my second phone to Tom R. to use for testing

Comments:
UI

  • When start up the QA, it appears with the blue background and Mapeo logo, would make more sense if the QA could start up with red background instead, to help differentiate.
  • The blue dot on the map screen showing current location appears underneath the orange dots of points - I think it would make more sense the other way round
  • When I started up offline, it said 'error loading map' - perhaps more useful to say something more instructional like "error loading map, - try going online or load an offline map"
  • In the language chooser it might make sense if the current chosen language appears at top of list, perhaps with font/colour differentiation or something.
  • When go to sync screen without any wifi network - the Wifi says: Wifi: - this isn't very useful, could it not say "device not connected to a wifi network" or "connect to a wifi network to syncronise" or something like that.
  • The script says there should be an optoin to "open settings" to go to the wifi menu - there is no "open settings" button - maybe the UI has changed @jencastrodoesstuff do we need to update the script?

Bugs / Issues

  • When I opened Mm, it was not connected to internet. The GPS details button said 'searching' but if clicked on it then the points had already been captured. Stayed like this for ages, until I connected to internet - could this be something to do with there not being a map? I could not reproduce this, despite opening and closing Mapeo a few times. - not blocking
  • the online map didn't load once I connected to internet until I had quit and reopened Mapeo - not blocking
  • When syncing with computer, for a brief moment on the phone it came up with an error message saying something like "Error in Mapeo database" - but it was too fast to take note of and then it said sync complete, and seemed to be complete. I could not reproduce this. - not blocking
  • After the sync there was an error message at bottom of screen, see photo below. I dismissed it.
    IMG_8897 - not blocking

@okdistribute okdistribute moved this from In progress to Testing in Tech Priorities Jul 14, 2020
@jencastrodoesstuff
Copy link

jencastrodoesstuff commented Jul 15, 2020

Gave RC830 a full test including install, load configurations, add, edit, share, delete, sync with Md &Mm. Karissa did minor corrections to characters for share function that she sent me.
There is that strange issue of data not appearing on the map for a while even though it is in the observation list. Tom identified it on his summary as well. This is a strange behavior I encountered with a guardaparque in the RCA but we couldn't figure out if it was time that made the points appear or connectivity to the internet. Can figure out the sequence for testing this for the next release.

@jencastrodoesstuff
Copy link

What is the process for us to review apps that are ready to release?

okdistribute and others added 10 commits July 16, 2020 20:08
Previously, <MapboxGL.Camera> was not rendered when location services
were off. This caused the <MapboxGL.ShapeSource> to not render (for
unknown reasons). This fix always renders MapboxGL.Camera and ignores
location updates if the map is not in follow mode.
* New translations en.json (French)

* New translations en.json (Spanish)

* New translations en.json (Vietnamese)

* New translations en.json (Portuguese, Brazilian)

* New translations en.json (Indonesian)

* New translations en.json (Khmer)

* New translations en.json (Thai)

* New translations en.json (Hindi)

* New translations en.json (Malay)

* New translations en.json (Burmese)

* New translations en.json (Nepali)

* New translations en.json (Lao)
* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Thai)

* New translations en.json (Nepali)

* New translations en.json (Nepali)
Copy link

@jencastrodoesstuff jencastrodoesstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed*
Install
load config
online map loads
*known issue: points don't appear in mapview when there is no online map and no offline map
offline map loads
center to location
live track location on map
GPS, precision update and details screen
observation points appear on map with GPS OFF

new observation: select category, add description add photos, add details, save
edit observation: edit category, edit description, add photos, edit details, save
*known issue: photos requires datestamp for verification purposes
manual entry GPS coordinates

Share with WhatsApp - custom formatting
Share with Email - custom subject line

Delete

Sync with Wifi
Syncing big databases from desktop* and mobile (900+ observations)
*known issue: sync process termination and error front end issues
Resyncing after errors (from previously interrupted syncs)

PASS
Release the hounds!!

@okdistribute okdistribute self-requested a review July 22, 2020 17:37
The 8.1.0-rc.2 seemed to be the cause of errors fetching tiles when the
device is offline
@gmaclennan gmaclennan merged commit 3c540b5 into deploy Jul 22, 2020
Tech Priorities automation moved this from Testing to Done Jul 22, 2020
@gmaclennan gmaclennan deleted the release/v2.1.0 branch July 22, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants