fix: Write preset tags to observations

[luandro]

Should solve #513

Add logic to include tags from category and clear tags from old category.

[gmaclennan]

Great stuff Luandro. I've made some suggestions that simplify the code and catch some edge-cases (undefined values).

Since this is quite a complex bit of code now, I think it's good to be really clear with naming variables to help future readers. Here's some ideas:

• selectedPreset = The preset selected by the user (currently called preset)
• currentDraftTags = The tags currently defined on draftValue (currently called oldTags)
• prevPresetTags = The tags from the previously selected preset (if there was one)
• updatedTags = draftTags with tags from the previously selected preset removed

Worth putting some comments in the code to clarify this.

Maybe avoid the newTags terminology, and instead just keep this as selectedPreset.tags, which is explicit.

Can you also check that these tags that come from the preset are not displayed in the ObservationView component? I don't think they are, since I think we only display tags defined referenced by fields in the preset, but worth checking. We will need to fix this on Desktop, because the Desktop code also shows tags on any observation that are not referenced by fields.

[luandro]

Thanks for thoughtful review @gmaclennan. Pushed new changes hopefully taking every comment into account.

[gmaclennan]

Great, just a couple more things, cleaning up the code.

Looks like the translations are in this branch - can you maybe rebase onto develop?

[luandro]

Looking much better now @gmaclennan, great tips 👍

[gmaclennan]

Getting there :)
One change, and a question.
Also, I need to get CI working again so that the tests run.

[gmaclennan]

Great, I'm waiting for Github actions to run on #515 so that I can test install of the compatible version of NDK

[gmaclennan]

@luandro I managed to fix the CI build, for more details of the error see #517. I'm wondering what the testing plan is for this to check it works? At a minimum, I would like to do a manual test to ensure that this works as intended, e.g. by using presets that define tags and checking that the created observations have those tags, and also checking changing the preset for an existing observation to ensure that tags are removed as planned.

We are also in dire need of strong unit tests for things like this, and that's certainly possible for this, using https://testing-library.com - if you feel up to it, it would be a great place to start getting unit tests in place.