Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show alert dialog when Mapeo is updated #555

Merged
merged 7 commits into from Apr 22, 2021

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Apr 20, 2021

Show an alert dialog when Mapeo is successfully updated. Fixes #548

The first release that includes this PR will not show anything (since without previously installed version info, it is impossible to tell the difference between an update and the first install, and we do not want to show this alert when the user first installs Mapeo).

Updates after this PR lands will show a dialog to the user letting them know that Mapeo has successfully updated. Requesting review of the language (see image below) from @jencastrodoesstuff @rudokemper @marcartro.

update-notifier

This PR stores a complete history of Mapeo installs, including the time that each update was installed. This information is currently unused, but could be useful for debugging purposes in the future.

@jencastrodoesstuff
Copy link

jencastrodoesstuff commented Apr 20, 2021

As long as translations work for this (for current Spanish and Portuguese speaking partners) I think it is fine until it gets design love down the road.

@gmaclennan gmaclennan merged commit e67f780 into develop Apr 22, 2021
@gmaclennan gmaclennan deleted the feat/update-notifier branch April 22, 2021 11:31
gmaclennan added a commit that referenced this pull request May 17, 2021
* develop:
  fix: Add missing moduleResolution to tsconfig
  add missing package-lock entry
  Update src/backend/tsconfig.json
  Update src/backend/tsconfig.json
  Update src/backend/tsconfig.json
  typescript setup for jsdoc
  fix: Add "Sranan Tongo" as an option in the language settings screen
  chore: Update package-lock
  chore: Revert package-lock to lockfileVersion 1
  chore(docs): min Node version for dev is v10
  chore(docs): docs on manual version names & codes
  Release v5.2.0 (#532)
  chore: Translations of new features coming in v5.3 (#552)
  feat: Show alert dialog when Mapeo is updated (#555)
  chore: Fix intermittently failing e2e test (#570)
  fix: Internationalize labels on "About Mapeo" screen (#560)
  chore: change to semver version names (#557)

# Conflicts:
#	src/backend/package-lock.json
#	src/backend/package.json
@achou11 achou11 mentioned this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Front) Display dialogue if user upgraded already
2 participants