chore: switch from tap to node:test and Borp #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a pretty mechanical change. To do this, I: * Uninstalled `tap` and replaced it with `borp` * Manually rewrote tests to use `node:assert` and `t.after` for cleanup See [multi-core-indexer#39] for a similar patch on another repo. [multi-core-indexer#39]: digidem/multi-core-indexer#39
Pull Request Test Coverage Report for Build 8361237491Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 8361237491Details
💛 - Coveralls |
gmaclennan
approved these changes
Mar 20, 2024
EvanHahn
added a commit
to digidem/mapeo-schema
that referenced
this pull request
Mar 28, 2024
This was a pretty mechanical change. To do this, I: * Uninstalled `tap` and replaced it with `node --test` * Manually rewrote assertions to use `node:assert` See [multi-core-indexer#39] and [mapeo-sqlite-indexer#27] for similar patches on other repos. [multi-core-indexer#39]: digidem/multi-core-indexer#39 [mapeo-sqlite-indexer#27]: digidem/mapeo-sqlite-indexer#27
EvanHahn
added a commit
to digidem/mapeo-schema
that referenced
this pull request
Mar 28, 2024
This was a pretty mechanical change. To do this, I: * Uninstalled `tap` and replaced it with `node --test` * Manually rewrote assertions to use `node:assert` See [multi-core-indexer#39] and [mapeo-sqlite-indexer#27] for similar patches on other repos. [multi-core-indexer#39]: digidem/multi-core-indexer#39 [mapeo-sqlite-indexer#27]: digidem/mapeo-sqlite-indexer#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a pretty mechanical change. To do this, I:
tapand replaced it withborpnode:assertandt.afterfor cleanupSee multi-core-indexer#39 for a similar patch on another repo.