Component export #54
Merged
Component export #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little tricky because Mapbox filters do not work on arrays. Instead we flatten the array into: arrayField.0: arrayValue0, arrayField.1: arrayValue1, arrayField.2: arrayValue2 Then pass the same filter to each of these and group with an ‘any’ filter.
This makes the whole thing self contained for export. Only using woff for now, wouldn’t make sense to embed woff2 as well. Space difference is minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export MapFilter as a React component, that can be imported and rendered.
Currently only expects one prop:
featureswhich should be an array of GeoJSON Point features.See example/index.js for how to use. For now properties that are dates must be manually coerced to Date type.
Should merge #53 first