Handle receiving a magic start sequence in two separate parts #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if the StreamProtocolHandler was fed bytes that contained only part of the Magic field that specifies the start of a message it would throw away that start as it couldn't find the whole field. Now, it is aware of that possibility and keeps enough bytes around that it won't miss a Magic field. Signed-off-by: Zach Varberg <Zachary.Varberg@Digi.com>
|
Tests on Travis failed at first but it was just a problem pulling from pypi, so I restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the StreamProtocolHandler was fed bytes that contained only
part of the Magic field that specifies the start of a message it would
throw away that start as it couldn't find the whole field. Now, it is
aware of that possibility and keeps enough bytes around that it won't miss
a Magic field.
Signed-off-by: Zach Varberg Zachary.Varberg@Digi.com