Merge pull request #9 from digipolisantwerp/feature/dontlogbuffer

don't log buffer
digipolisantwerp · Feb 23, 2022 · c1df91c · c1df91c
2 parents f6aa034 + 3e37c74
commit c1df91c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/helpers/formatter.js b/lib/helpers/formatter.js
@@ -5,6 +5,9 @@ const getCircularReplacer = () => {
   const seen = new WeakSet();
   return (key, value) => {
     if (typeof value === 'object' && value !== null) {
+      if (Buffer.isBuffer(value) || value.type === 'Buffer') {
+        return '[Buffer]';
+      }
       if (seen.has(value)) {
         return '[Circular]';
       }

diff --git a/test/log.test.js b/test/log.test.js
@@ -257,6 +257,22 @@ describe('Logs:', () => {
         message: 'logmessage Extrainfo: {"extraparam":"extravalue"}',
       }));
     });
+    it('{ message: "logmessage", extraparam: buffer }', async () => {
+      const buffer = Buffer.from('smdlfkjmsldjfmlskdjfmlskjfmlksdjflskdjf');
+      const logmessage = { message: 'logmessage', extraparam: buffer };
+      log(console, {
+        type: 'log',
+        override: true,
+      });
+      console.log(logmessage);
+      sinon.assert.calledWith(logstub.log, JSON.stringify({
+        timestamp: new Date().toISOString(),
+        type: ['technical'],
+        level: 'INFO',
+        correlationId: '',
+        message: 'logmessage Extrainfo: {"extraparam":"[Buffer]"}',
+      }));
+    });
   });
   describe('{ type: text }', () => {
     it('"logmessage"', async () => {