S-108582 Improve http client error and redirection handling #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpugar
requested changes
Apr 29, 2024
There was a problem hiding this comment.
I believe we would not change current implementation. Or if we do it's only to display the error message better somewhat what you did.
The implementation should really add additional method that would be equivalent of Do method on existing Go HTTP Client with addition of our creation of a configuration for the request.
gpugar
reviewed
May 2, 2024
http/http_client.go
Outdated
| return data, fmt.Errorf("%v - %s", resp.StatusCode, string(data[:])) | ||
| } | ||
|
|
||
| return data, err | ||
| } | ||
|
|
||
| // doSendHttpRequest sends an HTTP request with a custom configuration and headers, returns whole HTTP response. | ||
| func (httpClient *HttpClient) doSendHttpRequest(ctx context.Context, config *RequestConfig) (*http.Response, error) { |
There was a problem hiding this comment.
make it DoSendHttpRequest so it's usable outside of the package
gpugar
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S-108582