Expand upgrade validation testing (#19123)

* Remove duplication from tests * lint * lint * Simplify tests * lint * add more tests for dependency behaviour * track new test files * lint * add test for failure being only emitted in the module that originates it * fix stdout capture for rules_daml * lint * lint * Move CannotUpgradeView into own section * Fix more upgrades gen
digital-asset · May 23, 2024 · 935c3fb · 935c3fb
1 parent b06a9e8
commit 935c3fb
Show file tree

Hide file tree

Showing 65 changed files with 864 additions and 1,175 deletions.
diff --git a/sdk/compiler/damlc/tests/BUILD.bazel b/sdk/compiler/damlc/tests/BUILD.bazel
@@ -446,10 +446,67 @@ da_haskell_test(
 da_haskell_test(
     name = "upgrades",
     srcs = ["src/DA/Test/DamlcUpgrades.hs"],
+    compiler_flags = ["-Wno-unused-local-binds"],
     data = [
         "//compiler/damlc",
         "//daml-script/daml:daml-script.dar",
         "//daml-script/runner:daml-script-binary",
+        "//test-common:upgrades-CannotUpgradeView-files",
+        "//test-common:upgrades-FailWhenATopLevelEnumChangesChangesTheOrderOfItsVariants-files",
+        "//test-common:upgrades-FailWhenATopLevelVariantChangesChangesTheOrderOfItsVariants-files",
+        "//test-common:upgrades-FailsOnlyInModuleNotInReexports-files",
+        "//test-common:upgrades-FailsWhenATopLevelRecordAddsANonOptionalField-files",
+        "//test-common:upgrades-FailsWhenATopLevelRecordAddsAnOptionalFieldBeforeTheEnd-files",
+        "//test-common:upgrades-FailsWhenATopLevelVariantAddsAFieldToAVariantsType-files",
+        "//test-common:upgrades-FailsWhenATopLevelVariantAddsAVariant-files",
+        "//test-common:upgrades-FailsWhenATopLevelVariantRemovesAVariant-files",
+        "//test-common:upgrades-FailsWhenAnInstanceIsDropped-files",
+        "//test-common:upgrades-FailsWhenAnInterfaceIsDefinedInAnUpgradingPackageWhenItWasAlreadyInThePriorPackage-files",
+        "//test-common:upgrades-FailsWhenExistingFieldInTemplateChoiceIsChanged-files",
+        "//test-common:upgrades-FailsWhenExistingFieldInTemplateIsChanged-files",
+        "//test-common:upgrades-FailsWhenNewFieldIsAddedToTemplateChoiceWithoutOptionalType-files",
+        "//test-common:upgrades-FailsWhenNewFieldIsAddedToTemplateWithoutOptionalType-files",
+        "//test-common:upgrades-FailsWhenOldFieldIsDeletedFromTemplate-files",
+        "//test-common:upgrades-FailsWhenOldFieldIsDeletedFromTemplateChoice-files",
+        "//test-common:upgrades-FailsWhenTemplateAddsKeyType-files",
+        "//test-common:upgrades-FailsWhenTemplateChangesKeyType-files",
+        "//test-common:upgrades-FailsWhenTemplateChoiceChangesItsReturnType-files",
+        "//test-common:upgrades-FailsWhenTemplateRemovesKeyType-files",
+        "//test-common:upgrades-FailsWhenTwoDeeplyNestedTypeSynonymsResolveToDifferentDatatypes-files",
+        "//test-common:upgrades-FailsWithSynonymReturnTypeChange-files",
+        "//test-common:upgrades-FailsWithSynonymReturnTypeChangeInSeparatePackage-files",
+        "//test-common:upgrades-MissingChoice-files",
+        "//test-common:upgrades-MissingDataCon-files",
+        "//test-common:upgrades-MissingModule-files",
+        "//test-common:upgrades-MissingTemplate-files",
+        "//test-common:upgrades-RecordFieldsNewNonOptional-files",
+        "//test-common:upgrades-SucceedWhenATopLevelEnumAddsAField-files",
+        "//test-common:upgrades-SucceedsWhenATopLevelEnumChanges-files",
+        "//test-common:upgrades-SucceedsWhenATopLevelRecordAddsAnOptionalFieldAtTheEnd-files",
+        "//test-common:upgrades-SucceedsWhenATopLevelTypeSynonymChanges-files",
+        "//test-common:upgrades-SucceedsWhenATopLevelVariantAddsAVariant-files",
+        "//test-common:upgrades-SucceedsWhenATopLevelVariantAddsAnOptionalFieldToAVariantsType-files",
+        "//test-common:upgrades-SucceedsWhenAnInstanceIsAddedSeparateDep-files",
+        "//test-common:upgrades-SucceedsWhenAnInstanceIsAddedUpgradedPackage-files",
+        "//test-common:upgrades-SucceedsWhenAnInterfaceIsOnlyDefinedInTheInitialPackage-files",
+        "//test-common:upgrades-SucceedsWhenNewFieldWithOptionalTypeIsAddedToTemplate-files",
+        "//test-common:upgrades-SucceedsWhenNewFieldWithOptionalTypeIsAddedToTemplateChoice-files",
+        "//test-common:upgrades-SucceedsWhenTemplateChoiceInputArgumentHasChanged-files",
+        "//test-common:upgrades-SucceedsWhenTemplateChoiceReturnsATemplateWhichHasChanged-files",
+        "//test-common:upgrades-SucceedsWhenTwoDeeplyNestedTypeSynonymsResolveToTheSameDatatypes-files",
+        "//test-common:upgrades-SucceedsWhenUpgradingADependency-files",
+        "//test-common:upgrades-TemplateChangedKeyType-files",
+        "//test-common:upgrades-ValidUpgrade-files",
+        "//test-common:upgrades-WarnsWhenAnInterfaceAndATemplateAreDefinedInTheSamePackage-files",
+        "//test-common:upgrades-WarnsWhenAnInterfaceIsDefinedAndThenUsedInAPackageThatUpgradesIt-files",
+        "//test-common:upgrades-WarnsWhenAnInterfaceIsUsedInThePackageThatItsDefinedIn-files",
+        "//test-common:upgrades-WarnsWhenControllersOfTemplateChoiceAreChanged-files",
+        "//test-common:upgrades-WarnsWhenObserversOfTemplateChoiceAreChanged-files",
+        "//test-common:upgrades-WarnsWhenTemplateChangesEnsure-files",
+        "//test-common:upgrades-WarnsWhenTemplateChangesKeyExpression-files",
+        "//test-common:upgrades-WarnsWhenTemplateChangesKeyMaintainers-files",
+        "//test-common:upgrades-WarnsWhenTemplateChangesObservers-files",
+        "//test-common:upgrades-WarnsWhenTemplateChangesSignatories-files",
     ],
     hackage_deps = [
         "base",