You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also think we should:
a). deprecate the existing GetTransactionTrees GRPC Service:
// Read the ledger's filtered transaction stream for a set of parties.
rpc GetTransactions (GetTransactionsRequest) returns (stream GetTransactionsResponse);
// Read the ledger's complete transaction tree stream for a set of parties.
rpc GetTransactionTrees (GetTransactionsRequest) returns (stream GetTransactionTreesResponse);
It takes the same GetTransactionsRequest message as GetTransactions service. However it cannot handle template_ids defined in TransactionFilter message.
b). define new messages: GetTransactionTreesRequest and TransactionTreeFilter
c). define a new Transaction Tree service as:
While I agree that the current behavior is not so nice since it's not discoverable from the .proto definitions only, I do not think it's worth breaking backwards compatibility because of this. We've never actually heard a complaint about this, BTW.
However, I just checked and the documentation for this is severely lacking: the .proto files do not even mention this, as far as I can tell. This should definitely be fixed.
bitonic
changed the title
Ledger API TransactionService improvements
Improve documentation regarding transaction filtering limitations for GetTransactionTrees
Jun 6, 2019
Rescoped, see #1483 (comment)
GetTransactionTrees
GRPC Service does not supportTransactionTree
filtering by template ID:TODOs:
GetTransactionTrees
GRPC explaining the limitationscom.daml.ledger.rxjava.TransactionsClient#getTransactionsTrees
com.digitalasset.ledger.client.services.transactions.TransactionClient#getTransactionTrees
I also think we should:
a). deprecate the existing
GetTransactionTrees
GRPC Service:It takes the same
GetTransactionsRequest
message asGetTransactions
service. However it cannot handletemplate_ids
defined inTransactionFilter
message.b). define new messages:
GetTransactionTreesRequest
andTransactionTreeFilter
c). define a new Transaction Tree service as:
where
GetTransactionTreesRequest
message doe NOT allow passingtemplate_ids
.The text was updated successfully, but these errors were encountered: