Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign binaries #29

Closed
neil-da opened this issue Feb 25, 2019 · 3 comments
Closed

Sign binaries #29

neil-da opened this issue Feb 25, 2019 · 3 comments
Assignees
Labels

Comments

@neil-da
Copy link
Contributor

neil-da commented Feb 25, 2019

For general security reasons it would be nice to sign all binaries we produce for a release, including the installer. No need to do it immediately, but in the medium term.

CC @shaul-da

@garyverhaegen-da
Copy link
Contributor

First step would be to have a secure signing key on the CI server. I'm not sure our current "secrets" infrastructure is fit for that kind of purpose, so I'd start by reviewing that.

@ghost ghost transferred this issue from another repository Apr 1, 2019
@ghost ghost added the component/build-system Build system label Apr 1, 2019
@ghost ghost added this to the Backlog milestone Apr 1, 2019
@neil-da
Copy link
Contributor Author

neil-da commented May 21, 2019

Turns out to be quite important for the installer itself, or we get Windows defender being upset.

@cocreature
Copy link
Contributor

Our Windows installer is now signed. If we decide to sign other things (signing Maven artifacts is already tracked as part of the work towards publishing to Maven central), let’s open separate issues for that.

hsenag pushed a commit to hsenag/daml that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants