Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new endpoint for create-and-exercise #4507

Closed
S11001001 opened this issue Feb 13, 2020 · 0 comments · Fixed by #4754
Closed

new endpoint for create-and-exercise #4507

S11001001 opened this issue Feb 13, 2020 · 0 comments · Fixed by #4754
Assignees
@leo-da
Labels
component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components.
Milestone
HTTP JSON API Mai...

Comments

@S11001001
Copy link
Contributor

Support #382 create-and-exercise command.

Request format:

{"templateId": ...,
 "payload": ...,
 "choice": ...,
 "argument": ...}

These field names ⬆️ match the create and exercise endpoints.

Response format: exactly the resulting transaction tree you get from ledger-API in submit-and-wait, formatted exactly as for the exercise endpoint.
@S11001001 S11001001 added the component/json-api HTTP JSON API label Feb 13, 2020
@S11001001 S11001001 added this to the HTTP JSON API Maintenance milestone Feb 13, 2020
@leo-da leo-da self-assigned this Feb 26, 2020
@leo-da leo-da added the wip-issue This issue is being worked on. Use draft PRs for work in progress PRs. label Feb 26, 2020
@leo-da leo-da mentioned this issue Feb 27, 2020
Merged
6 tasks
leo-da added a commit that referenced this issue Feb 28, 2020
@leo-da
Update docs
6dc1491 
CHANGELOG_BEGIN

[JSON API - Experimental]
Add ``/v1/create-and-exercise`` JSON API endpoint. See #4507.

CHANGELOG_END
@mergify mergify bot closed this as completed in #4754 Mar 2, 2020
mergify bot pushed a commit that referenced this issue Mar 2, 2020
@leo-da
Add create-and-exercise JSON API endpoint (#4754)
93329ac 
* CreateAndExerciseCommand JSON decoding

* create-and-exercise endpoint WIP

* create-and-exercise endpoint + test, WIP

* create-and-exercise test

* Update docs

CHANGELOG_BEGIN

[JSON API - Experimental]
Add ``/v1/create-and-exercise`` JSON API endpoint. See #4507.

CHANGELOG_END

* Cleaning up domain JSON encoder/decoder, trying to get rid of HasTemplate

* Cleaning up domain JSON encoder/decoder, trying to get rid of HasTemplate

* Addressing code review comments
@stefanobaghino-da stefanobaghino-da added the team/ledger-clients Related to the Ledger Clients team's components. label Aug 31, 2021
@S11001001 S11001001 removed the wip-issue This issue is being worked on. Use draft PRs for work in progress PRs. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leo-da leo-da

Labels
component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
HTTP JSON API Maintenance
Development

Successfully merging a pull request may close this issue.

Add create-and-exercise JSON API endpoint digital-asset/daml
3 participants
@S11001001 @leo-da @stefanobaghino-da