fix duplicate contract ids when loading scenarios with pass
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
2 times, most recently
from
b8da454
to
8be393c
Compare
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
from
8be393c
to
bd98b66
Compare
|
@gaboraranyossy-da ready now, please take a look. |
gabor-aranyossy
suggested changes
May 13, 2019
ledger/sandbox/src/main/scala/com/digitalasset/platform/sandbox/cli/Cli.scala
Show resolved
Hide resolved
.../sandbox/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/ScenarioLoader.scala
Show resolved
Hide resolved
...r/sandbox/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/sql/SqlLedger.scala
Outdated
Show resolved
Hide resolved
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
2 times, most recently
from
d50fb35
to
7657d95
Compare
gabor-aranyossy
approved these changes
May 14, 2019
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
from
b7d245c
to
588efa3
Compare
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
from
588efa3
to
660db85
Compare
bitonic
force-pushed
the
duplicate-contract-ids-1079
branch
from
660db85
to
6d81164
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1079.
draft because I need to add the test for the postgresql backend.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.