start: work with console #14178
Merged
start: work with console #14178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug reported by `kctam` on [the forum]: that [the forum]: https://discuss.daml.com/t/daml-start-then-using-daml-canton-console-to-access/4723 ``` daml start ``` followed by ``` daml canton-console ``` doesn't work (because the console can't know which ports to connect to). I'm very much not familiar at all with this area of the repo, so it's possible this is not the right approach to solving that at all. Please feel free to close and solve it in a better way if you know better. CHANGELOG_BEGIN - When using `daml start` (with no sandbox port configured in `daml.yaml`), the sandbox ports will no longer be random, and instead be the same ports as a plain `daml sandbox`. CHANGELOG_END
garyverhaegen-da
requested review from
remyhaemmerle-da and
ray-roestenburg-da
as code owners
cocreature
reviewed
Jun 14, 2022
| @@ -69,9 +69,9 @@ getPortForSandbox defaultPortSpec portSpecM = | |||
| determineCantonOptions :: Maybe SandboxPortSpec -> SandboxCantonPortSpec -> FilePath -> IO CantonOptions | |||
| determineCantonOptions ledgerApiSpec SandboxCantonPortSpec{..} portFile = do | |||
| cantonLedgerApi <- getPortForSandbox (SpecifiedPort (SandboxPort 6865)) ledgerApiSpec | |||
| cantonAdminApi <- getPortForSandbox FreePort adminApiSpec | |||
There was a problem hiding this comment.
this seems sensible but I think it’s worth trying to dedup the default ports for daml start & daml sandbox between the two to avoid this getting out of sync in the future.
There was a problem hiding this comment.
I pushed a new commit. Is this what you had in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported by
kctamon the forum: thatfollowed by
doesn't work (because the console can't know which ports to connect to).
I'm very much not familiar at all with this area of the repo, so it's possible this is not the right approach to solving that at all. Please feel free to close and solve it in a better way if you know better.