New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daml-doc md
#16475
Fix daml-doc md
#16475
Conversation
Md fixes not tested, waiting on information for how to run hoogle with the generated file |
Confirmed hoogle points to |
I don't know if this is common but I worry that someone might be generating the |
Fair point, I can add a |
Seems like odd UX though to generate |
Alternatively, I may add a little warning note if you use format=md without doc-ext=md. Do you think thats reasonable? |
yeah honestly I'm not sure what's the best for UX here. At least we don't seem to be using |
Yeah I believe our own docs are generated by calling the internals directly |
What do you think about the warning? |
Also, note that the paths with |
hm yeah that sounds fine too |
Do we consider |
I think it's fine if it's just ignored in that case |
@@ -151,7 +153,7 @@ documentation numProcessors = Damldoc | |||
optOutputFormat = | |||
option readOutputFormat $ | |||
metavar "FORMAT" | |||
<> help "Output format. Valid format names: rst, md, markdown, html, hoogle, json (Default: markdown)." | |||
<> help "Output format. Valid format names: rst, md, markdown, html, json (Default: markdown)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for spotting this :)
Resolves #16474
Relevant question: https://discuss.daml.com/t/markdown-referencing-html-in-generated-doc/6222
Simply switches the generated
md
files and hoogle db to use.md
on internal global anchors, when run withformat=md