daml damlc init reads build-options from daml.yaml
#16492
Conversation
akrmn
requested review from
basvangijzel-DA,
remyhaemmerle-da,
dylant-da and
samuel-williams-da
as code owners
compiler/damlc/lib/DA/Cli/Damlc.hs
Outdated
| (errMsgs, parseResult) = parse args | ||
| Command _ _ io <- handleParseResult parseResult | ||
| forM_ errMsgs $ \msg -> do | ||
| hPutStrLn stderr msg | ||
| withProgName "damlc" io | ||
|
|
||
| -- | Commands for which we add the args from daml.yaml build-options. | ||
| cmdUseDamlYamlArgs :: [CommandName] |
There was a problem hiding this comment.
it's not my first time fixing a ticket like this, so I thought this would help find the place to change if we get another one.
There was a problem hiding this comment.
Are there any other cases that this might arise for? I'm not entirely sure of the context, but at what point will it make more sense to have a reject list, rather than an accept one
There was a problem hiding this comment.
thanks for pointing this out. I looked at the other constructors of CommandName and I think DocTest and Lint probably need to do this too, so I added them. I also changed the type of cmdUseDamlYamlArgs, now it's a predicate on CommandName so we have to be exhaustive, and I've added comments explaining the Falses
compiler/damlc/lib/DA/Cli/Damlc.hs
Outdated
| (errMsgs, parseResult) = parse args | ||
| Command _ _ io <- handleParseResult parseResult | ||
| forM_ errMsgs $ \msg -> do | ||
| hPutStrLn stderr msg | ||
| withProgName "damlc" io | ||
|
|
||
| -- | Commands for which we add the args from daml.yaml build-options. | ||
| cmdUseDamlYamlArgs :: [CommandName] |
There was a problem hiding this comment.
Are there any other cases that this might arise for? I'm not entirely sure of the context, but at what point will it make more sense to have a reject list, rather than an accept one
|
As a side note, is there any damage to forwarding flags that aren't used? |
oh, this is a fair point, you'd get an error if I'm thinking, perhaps it would make sense to have different fields in I think the problematic flags are few, though, since most commands use EDIT: #16518 |
Closes #14591