Bump stackage snapshot to lts-19.33
#17795
Conversation
| @@ -471,7 +471,7 @@ locateCppPath = do | |||
| -- the resources directory because the target produces a tarball which | |||
| -- has the executable directly under the top directory. | |||
| -- See @bazel_tools/packaging/packaging.bzl@. | |||
| , runfilesPathPrefix = "stackage" </> "hpp-0.6.4" </> "_install" </> "bin" | |||
| , runfilesPathPrefix = "stackage" </> "hpp-0.6.5" </> "_install" </> "bin" | |||
There was a problem hiding this comment.
So, this was the root cause of the missing field Settings.sPgm_P errors: the version bump meant the hpp bin moved, so we couldn't locate it, so adjustDynFlags couldn't set sPgm_P and sOpt_P, so the fields were indeed missing so GHC crashed in doCpp.
This is not the final fix since we want to prevent this from happening again. I want to remove the hardcoded version of hpp here - using a copy instead of the @stackage/hpp bin directly should work. I also want to make this crash with a clear error if the file is missing instead of returning a Nothing that will silently give us a partial Settings.
There was a problem hiding this comment.
…sion in haskell code
akrmn
force-pushed
the
akrmn/bump-stack-snapshot
branch
from
a7ab80c
to
4e63a74
Compare
akrmn
changed the title
lts-19.33
akrmn
requested review from
basvangijzel-DA,
remyhaemmerle-da,
dylant-da,
samuel-williams-da and
paulbrauner-da
as code owners
| -- but comes from the stackage target, so the prefix is different | ||
| -- from that of the dist target. | ||
| , runfilesPathPrefix = mainWorkspace </> "compiler" </> "damlc" | ||
| -- //compiler/damlc:hpp-copy |
There was a problem hiding this comment.
I'm guessing this means "we're getting hpp from this target" but it wasn't clear upon first read. Maybe elaborate a bit. (I realize this is just a rephrasing of the existing comment.)
No description provided.