New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the Bearer
prefix in bindings.
#5484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m a bit confused, I would have expected that we enforce this on the server side as well. Without doing this, this just limits the ledgers we can interact with.
Changelog is missing DAML Script,DAML Repl and the ledger bindings and I expect that there are also some docs that mention this (at the very least the docs for DAML Script over the JSON API has a caveat that it does not expect the Bearer
prefix in the token file which is now redundant).
@cocreature: I'm making a few more changes at the moment. I'm thinking of dropping the |
This means it must be removed in the token files. CHANGELOG_BEGIN [Extractor]: The ``Bearer `` prefix can be removed from the token file. It is added automatically. [Navigator]: The ``Bearer `` prefix can be removed from the token file. It is added automatically. CHANGELOG_END
CHANGELOG_BEGIN [DAML Script] The ``Bearer `` prefix can be removed from the token file. It is added automatically. [DAML Repl] The ``Bearer `` prefix can be removed from the token file. It is added automatically. [Scala Bindings] The ``Bearer `` prefix can be removed from the token. It is added automatically. [Java Bindings] The ``Bearer `` prefix can be removed from the token. It is added automatically. CHANGELOG_END
217d539
to
37218df
Compare
CHANGELOG_BEGIN [DAML Integration Kit] ``AuthService`` implementations MUST read the ``Authorization`` header and the value of the header MUST start with ``Bearer ``. CHANGELOG_END
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ,thanks a lot! And sorry for the confusion.
No no, thanks for asking the right questions, @cocreature! |
This means it must be removed in the token files.
CHANGELOG_BEGIN
[Extractor]: The
Bearer
prefix must be removed from the token file.[Navigator]: The
Bearer
prefix must be removed from the token file.CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.