allow secure connection from JSON API to ledger #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the TLS config code is shared with extractor, where it is more fully tested; we just do a sanity check here
S11001001
commented
Apr 15, 2020
| @@ -99,6 +99,8 @@ object Arguments { | |||
| .mkString(", ")}. Default: ${Arguments.default.time.name}") | |||
| .action((t, arguments) => arguments.copy(time = t)) | |||
|
|
|||
| // TODO: the 4 following TLS options can be defined by TlsConfigurationCli instead | |||
There was a problem hiding this comment.
This is deliberately left in; the change should be in a separate PR.
CHANGELOG_BEGIN - [JSON API] New ``--pem``, ``--crt``, ``--cacrt``, and ``--tls`` options for securing the connection between JSON API server and ledger. See `issue #2540 <https://github.com/digital-asset/daml/issues/2540>`__. CHANGELOG_END
S11001001
requested review from
bame-da,
hurryabit,
leo-da,
nemanja-da and
rautenrieth-da
as code owners
hurryabit
reviewed
Apr 16, 2020
leo-da
approved these changes
Apr 16, 2020
stefanobaghino-da
added
the
team/ledger-clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicates the command-line options related to TLS, and how they play into ledger client configuration, from extractor, for json-api. Fixes #2540.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.