Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an --output-file option to DAML Script #5590

Merged
merged 1 commit into from Apr 17, 2020
Merged

Conversation

cocreature
Copy link
Contributor

This PR adds an --output-file option to DAML Script that writes the
result of a DAML Script to a file and complements the --input-file option.

changelog_begin

  • [DAML Script] daml script now has a `--output-fileoption that can be used to specify a file the result of the script should be written to. Similar to--input-file`` the result will be output in
    the DAML-LF JSON encoding.

changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This PR adds an --output-file option to DAML Script that writes the
result of a DAML Script to a file and complements the --input-file option.

changelog_begin

- [DAML Script] ``daml script`` now has a `--output-file`` option that
  can be used to specify a file the result of the script should be
  written to. Similar to ``--input-file`` the result will be output in
  the DAML-LF JSON encoding.

changelog_end
@aherrmann-da
Copy link
Contributor

The markup in the changelog message has a backtick missing before --output-file.

Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cocreature
Copy link
Contributor Author

The markup in the changelog message has a backtick missing before --output-file.

At this point the changelog first goes to a google doc, then back to rst and then back to markdown. All hope of preserving markup is lost 😭

@cocreature cocreature merged commit 7067fa4 into master Apr 17, 2020
@cocreature cocreature deleted the script-outputfile branch April 17, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants