Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include contract keys in the Scala codegen output plan when using --root #6696

Merged
merged 4 commits into from Jul 10, 2020

Conversation

S11001001
Copy link
Contributor

Fix to #6660: when filtering with --root, contract keys weren't included in the Scala codegen output plan. We fix it by refining #1586, bringing the key types in line with the way types are generally treated in the definition interface types: as the Ty type variable.

Thanks to @SamirTalwar-DA for discovering.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@S11001001 S11001001 added the component/scala-ecosystem Scala development experience label Jul 10, 2020
@S11001001 S11001001 added this to the runtime/backlog milestone Jul 10, 2020
@S11001001 S11001001 requested a review from leo-da July 10, 2020 18:01
@S11001001 S11001001 self-assigned this Jul 10, 2020
@S11001001 S11001001 merged commit dba6ac7 into master Jul 10, 2020
@S11001001 S11001001 deleted the 6660-depend-on-key branch July 10, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scala-ecosystem Scala development experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants