Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Show instance for Ordering #7068

Merged
merged 1 commit into from Aug 10, 2020
Merged

Add a Show instance for Ordering #7068

merged 1 commit into from Aug 10, 2020

Conversation

cocreature
Copy link
Contributor

Requested in
https://discuss.daml.com/t/why-isnt-ordering-an-instance-of-show-in-daml/1007
Seems like a very reasonable thing to have.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Requested in
https://discuss.daml.com/t/why-isnt-ordering-an-instance-of-show-in-daml/1007
Seems like a very reasonable thing to have.

changelog_begin
changelog_end
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deserve a changelog entry?

@cocreature
Copy link
Contributor Author

Does this deserve a changelog entry?

good point, I’ll add it on merging.

@cocreature cocreature merged commit f897e7a into master Aug 10, 2020
@cocreature cocreature deleted the ordering-show branch August 10, 2020 08:40
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants