Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish trigger service EE fat JARs #9363

Merged
merged 2 commits into from Apr 9, 2021
Merged

Publish trigger service EE fat JARs #9363

merged 2 commits into from Apr 9, 2021

Conversation

cocreature
Copy link
Contributor

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Publish trigger service EE fat JARs
5d5d138 
changelog_begin
changelog_end
cocreature
cocreature commented Apr 8, 2021
View reviewed changes
ci/copy-unix-release-artifacts.sh Outdated
bazel build //triggers/service:trigger-service-binary-ce_deploy.jar
cp bazel-bin/triggers/service/trigger-service-binary-ce_deploy.jar $OUTPUT_DIR/github/$TRIGGER_SERVICE
bazel build //triggers/service:trigger-service-binary-ee_deploy.jar
cp bazel-bin/triggers/service/trigger-service-binary-ee_deploy.jar $OUTPUT_DIR/artifactory/$TRIGGER_SERVICE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could include -ee in the file name. I have a slight preference for not doing it here since we don’t do it for other fat JARs like non-repudiation but I don’t feel all that strongly about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a preference for including the ee for the same reason we include the version number in the filename (rather than just as part of the path in the download URL): I expect people will download both and it's awkward if they have two files with the same name and different contents.

Copy link
Contributor Author

@cocreature cocreature Apr 8, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you feel about including it for non-repudiation fat jar (I think I’d leave it out of the maven artifacts) as well? I think nobody has access to that so far so we can change it and we would be consistent for everything that is officially in connect (the script and trigger runner are not available to everyone)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed both in d1aa199 ptal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd include it everywhere. Obviously the naming conflict doesn't apply to EE-only components, but I think consistency has value here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d1aa199 looks good, thanks!

@cocreature
Include ee in artifact name
d1aa199 
changelog_begin
changelog_end
@cocreature cocreature merged commit dc4b9e5 into main Apr 9, 2021
@cocreature cocreature deleted the publish-trigger-service branch April 9, 2021 11:24
azure-pipelines bot pushed a commit that referenced this pull request Apr 14, 2021
release 1.12.0-snapshot.20210413.6706.0.2dc09ba2
67ac433 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@remyhaemmerle-da is in charge of this release.

Commit log:
```
2dc09ba LF: fix contract ID freshness check (#9370)
1627b70 Pattern matching for RoundingMode (#9381)
b41e1ed fix daml-lf/governance.rst (#9399)
8f885f4 MutableCacheBackedContractStore implementation (#9378)
7890381 Publish EE JSON API to artifactory (#9392)
6ab9655 Fix scala version in quickstart-scala (#9401)
87d3f89 offboarding @hurryabit (#9398)
29fcebe Fix recording of  cache metrics [KVL-888] (#9382)
67b0e2b Drop hurryabit from release rotation 😭 (#9393)
24c64ce Clean up participant-integration-api command line help page (#9385)
2f4b32f update NOTICES file (#9391)
cda2940 KVL-861 Add support for dumping expected and actual updates in the integrity checker (#9379)
7fc86b7 Fix flaky StateCacheSpec test (#9389)
301dcd9 DPP-316: Enable the use of the append only index database (#9368)
9ac74e6 Oracle json-api: websockets and testing (#9278)
104ad06 Streaming contract state events (on the append-only schema) [DPP-304] (#9365)
da6a0d6 Extend prometheus metrics with min/mean/max values (#9380)
10edc66 Implement Prometheus metrics back-end (#9373)
89b5dbb LedgerDao and ContractsReader interface updates (#9349)
8480032 daml package: bump timeout for tests (#9377)
bca24a9 Make LogEntryId computation strategy injectable to submission validators (#9302)
78dc238 StateCache implementation for mutable contract state (#9299)
91b65e8 Patch hoogle binary to include bugfix (#9366)
dc4b9e5 Publish trigger service EE fat JARs (#9363)
11e5dd3 link to postgres docs (#9353)
f84b6ab daml build: add a --access-token-file for remote dependencies (#9358)
dfe26b9 fix hoogle (#9364)
c220e05 infra/hoogle: use nix (#9362)
5a983e3 Deduplicate LfValueTranslation cache (#9354)
e84c954 Expose Oracle support in the EE trigger service (#9342)
0303017 Delete "testing with scenarios" section (#9360)
587bff2 Fix comment formatting in state (#9359)
4c231dc Update canton tests to pre 0.23.0 release (#9356)
bc4e00b Run Canton tests with JDK11 (#9355)
948d4dd infra: hoogle blue/green tf (#9351)
69ecf57 Removing Git as a prerequisit from the GSG (#9202)
2745bc0 macos: move cache setup to step 2 (#9350)
38c417e bump hoogle ubuntu (#9344)
a2ccf1b LF: release LF 1.13 archive snapshot (#9348)
867e625 Add exception handling to Daml Script (#9324)
c97db24 fix macOS cache cleaning (#9343)
bac3521 Add sqrt to DA.Math (#9346)
06701f7 Expose rounding modes as constructors + add BigNumeric docs. (#9336)
b90a9c3 Remove exception message from AnyException (#9328)
35759fc LF: Freeze archive proto for LF 1.13 (#9345)
0251e93 Improve TX normalization. (#9341)
2b1f882 daml-ledger: new list-packages command (#9325)
568a852 LF: release preview of LF 1.13 (#9329)
8b8f736 update compat versions for 1.12.0-snapshot.20210406.6646.0.631db446 (#9332)
960134d Fix typo in profiler docs, file name starts with profile (not profiler) (#9338)
0eac00f Avoid deprecated forHostWithLedgerIdDiscovery in quickstart-java (#9337)
5b11571 Introduce parallel indexer (#9304)
e84a94e Update issue number for BigNumeric Divisible instance. (#9334)
8f7ef05 Avoid mention of scenarios in Sandbox docs (#9335)
93de56d Optimize race condition integration tests [DPP-330] (#9320)
74956e2 LF: BigNumeric spec. (#8899)
4d0c6db daml ledger: better error messages for missing host/port args (#9322)
247a1a3 snapshot to test non-repudiation publish (#9326)
7b3b669 LF: add test for bigNumeric operations (#9310)
fd63cf0 use {tag, value} format for SQLizing advanced JSON queries (#9321)
```
Changelog:
```
- [Engine] Fix contract ID freshness check when validating transaction
- [Integration Kit] new streaming query for contract state events
- [Integration Kit] indexing contract keys for consuming exercise events
- Add prometheus metrics as a cli option in the participant integration api
[daml build] A new flag `--access-token-file` is added for the `daml
build` command. It allows the specify the path to an access token to
authenticate against the ledger API. This is needed if the project
depends on a remote Daml package hosted on such a ledger. Alternatively,
the path to the token can also be specified in the `daml.yaml` project
file under the `ledger.access-token-file` field.
[daml packages] A new `daml packages list` command has been added to
list packages deployed on a remote Daml ledger.
- Daml: (Early access) add support for BigNumeric
- [HTTP JSON API] Range queries within variant data would not return matching
  data when using the PostgreSQL backend with JSON API; this is fixed.
  See `issue #9321 <https://github.com/digital-asset/daml/pull/9321>`__.
```

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cocreature @garyverhaegen-da