Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the getSigFile method in BinarySignatureIdentifier public #199

Closed
JSLair opened this issue Feb 27, 2018 · 2 comments · Fixed by #202
Closed

Make the getSigFile method in BinarySignatureIdentifier public #199

JSLair opened this issue Feb 27, 2018 · 2 comments · Fixed by #202
Labels
enhancement
Milestone
6.5

Comments

@JSLair
Copy link
Contributor

JSLair commented Feb 27, 2018

Could you make the getSigFile method in BinarySignatureIdentifier public, cause I need it to order the results with priorities?
@anjackson
Copy link

+1 that would be great. Currently I work around this by adding a class in the same package that exposes the method (see here) but I'd rather be able to do this cleanly.

@alexgreenDP alexgreenDP added this to the 6.5 milestone Mar 5, 2018
@alexgreenDP
Copy link

Yes this should be possible. We will add it to our next release.

@adamretter adamretter mentioned this issue May 16, 2018
Merged
adamretter added a commit that referenced this issue May 16, 2018
@adamretter
Merge pull request #202 from rhubner/issue/199-getSigFile
f618938 
Make getSigFile() public. #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.5
Development

Successfully merging a pull request may close this issue.

Make getSigFile() public. #199
4 participants
@anjackson @jcharlet @alexgreenDP @JSLair