Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles produced now have Windows ends (CR+Newline) rather than just Unix (Newline) #440

Closed
Dclipsham opened this issue Apr 3, 2020 · 8 comments · Fixed by #447
Closed
Assignees
Labels
Milestone

Comments

@Dclipsham
Copy link

Reported via external testing - is causing issues where DROID is chained with other scripts handling DROID's output

@DavidUnderdown
Copy link

Tricky one - strictly speaking Windows endings are specified by RFC 4180 so we are now producing better CSV files than we were previously

@adamretter
Copy link
Contributor

Where in doubt, stick to the specs ;-)

@Dclipsham
Copy link
Author

not keen on unplanned behaviour changes though, particularly when they have the potential to break things downstream. Would be more comfortable with introducing a preference toggle.

@adamretter
Copy link
Contributor

@Dclipsham Or... you could switch DROID to Semantic Versioning and then you could make such a change in a Major version/

@jcharlet
Copy link
Contributor

jcharlet commented Apr 7, 2020

So what should we do here as a fix on 6.5 for @Dclipsham ? Simply put back previous Unix ends? Where is that happening, how to reproduce exactly (export / save profile / GUI / CLI ?)

@jcharlet jcharlet added this to Backlog in DROID Kanban board 6.5 via automation Apr 7, 2020
@jcharlet jcharlet self-assigned this Apr 7, 2020
@jcharlet
Copy link
Contributor

as part of unix scripts on windows machine

@jcharlet
Copy link
Contributor

check on 6.4 vs 6.5 on Linux and windows
if regression since 6.4, need to understand what causes it and possibly needs to add toggle to choose output format (windows with CR OR Unix)

@jcharlet jcharlet moved this from Backlog to In progress in DROID Kanban board 6.5 Apr 15, 2020
@Dclipsham
Copy link
Author

I'm proposing to revert to existing behaviour (LF only) for DROID 6.5, and putting future change to community for consideration - https://groups.google.com/forum/#!topic/droid-list/CX2ZcyS64xQ

@jcharlet jcharlet moved this from In progress to Review in progress in DROID Kanban board 6.5 Apr 21, 2020
DROID Kanban board 6.5 automation moved this from Review in progress to Done Apr 23, 2020
@jcharlet jcharlet added the bug label Apr 28, 2020
@jcharlet jcharlet added this to the 6.5 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants