-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: put back LF (unix) line separators in csv exports #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire file seems to have been reformatted? I can't spot the change :-(
argh sorry @adamretter , you can ignore whitespace changes. will undo that while fixing the checkstyle issue. |
7d56263
to
c6a31ba
Compare
df8a784
to
49d3951
Compare
49d3951
to
917c4f6
Compare
@adamretter finally understood what the issue was.. and funny enough, it was the way my IDE was formatting the file using.... Unix LF instead of Windows CRLF, which changed the whole files. after a big of fighting with it, I fixed it, checkstyle issues and unit tests on windows. Should be fine now. |
Are you using Intellij? If so it normally follows whatever your git repo is configured for I think |
yes but for some reason if there was already files staged, it wouldn't see the change when I update the file format (with intellij or unix2dos shell command). |
Issue
Fix #440
Context
this is new in 6.5.
This is due to a change in the library used to create CSV format (done by @adamretter to improve processing speed).
The library by default outputs files in a different format according to the operating system (using the operating system's own convention), while the previous one just used Unix format.
Solution
manually set the CSV format back to Unix.
Acceptance tests