Fixes broken test when built on non-english locale #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileUtilTest tests the output of FileUtil.formatFileSize() (which depends on the locale of the machine the test is run on) against a literal string (which does not depend on the locale). This will fail on non-english locales. This fix uses the decimal separator and grouping separator of the machine running the test and should make the test independent of the locale it is executed on. This PR is the exact solution already pointed out in the comments of Fixes #197 and #198.
|
Hello @dl1ely , thanks for your pull request. It looks really great. At the moment I'm on holiday, I will look on it when I get back next week. Radek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUtilTest tests the output of FileUtil.formatFileSize() (which
depends on the locale of the machine the test is run on) against a
literal string (which does not depend on the locale).
This will fail on non-english locales. This fix uses the decimal
separator and grouping separator of the machine running the test and
should make the test independent of the locale it is executed on.
This PR is the exact solution already pointed out in the comments of
#197
Fixes #197 and #198.