Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent creation of rubbish files during unit tests #346

Merged
merged 5 commits into from
Jan 20, 2020
Merged

prevent creation of rubbish files during unit tests #346

merged 5 commits into from
Jan 20, 2020

Conversation

jcharlet
Copy link
Contributor

creates all test related files in target folder rather than src temporary folders or module root folder.

@jcharlet jcharlet added this to the 6.5 milestone Jan 2, 2020
@jcharlet jcharlet force-pushed the fix_utest branch 2 times, most recently from 57ebfc5 to bc40a70 Compare January 7, 2020 08:53
@jcharlet jcharlet self-assigned this Jan 17, 2020
@jcharlet jcharlet requested review from sparkhi and removed request for LauraDamianTNA January 17, 2020 14:02
@jcharlet
Copy link
Contributor Author

build fixed,
ready to review and merge

@jcharlet
fix: minor: change to DEBUG noisy Warn messages when starting app "Si…
01262a9 
…gnature will always scan up to maximum bytes."
@jcharlet
Copy link
Contributor Author

jcharlet commented Jan 17, 2020 •
edited

added a minor commit to set verbose log as DEBUG as agreed with David on Trello https://trello.com/c/O1oVZHHI/35-2-jeremie-acceptance-tests#comment-5e13285241ce5684aa001fd9
(to avoid creating a separate branch, still part of cleaning the app..)

@jcharlet
Copy link
Contributor Author

to test this PR: mvn clean compile test the project and check we have no files to be added to github

@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 Jan 17, 2020
@jcharlet jcharlet assigned sparkhi and unassigned jcharlet Jan 20, 2020
@jcharlet jcharlet removed the request for review from sparkhi January 20, 2020 08:50
jcharlet
jcharlet commented Jan 20, 2020
View reviewed changes
Copy link
Contributor Author

@jcharlet jcharlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better way to deal with temporary files, learned something, thanks Saurab!

@sparkhi sparkhi merged commit 3b169bc into digital-preservation:master Jan 20, 2020
DROID Kanban board 6.5 automation moved this from In progress to Done Jan 20, 2020
@jcharlet jcharlet deleted the fix_utest branch January 20, 2020 09:33
@jcharlet jcharlet restored the fix_utest branch January 20, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sparkhi sparkhi

Labels
enhancement
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcharlet @sparkhi