Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced the jUnit TemporaryFolder rule for automatic cleanup of fi… #358

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Introduced the jUnit TemporaryFolder rule for automatic cleanup of fi… #358

merged 1 commit into from
Jan 21, 2020

Conversation

sparkhi
Copy link
Collaborator

@sparkhi sparkhi commented Jan 21, 2020

…les created during tests

The cleanup should happen automatically.
For testing, you could build it locally and make sure that no additional files appear within the source tree. Also check that no additional files appear under the 'tmp' folder.

Also cleaned up imports and removed unwanted static declaration

@sparkhi sparkhi requested a review from jcharlet January 21, 2020 10:56
@sparkhi sparkhi self-assigned this Jan 21, 2020
jcharlet
jcharlet approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jcharlet jcharlet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve code changes.
and tested the following on droid root folder:

  • run tests with mvn clean compile test
  • git status indicated no new file to commit
  • checked all "tmp" folders with find and ls: all are empty

@jcharlet jcharlet added this to the 6.5 milestone Jan 21, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Jan 21, 2020
@jcharlet jcharlet added the bug label Jan 21, 2020
@jcharlet jcharlet merged commit 26394f8 into master Jan 21, 2020
DROID Kanban board 6.5 automation moved this from In progress to Done Jan 21, 2020
@jcharlet jcharlet deleted the cleanup-test-files-leftover-pr-346 branch January 21, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcharlet jcharlet jcharlet approved these changes

Assignees

@sparkhi sparkhi

Labels
bug
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sparkhi @jcharlet