Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging #366

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix logging #366

merged 1 commit into from
Jan 30, 2020

Conversation

jcharlet
Copy link
Contributor

@jcharlet jcharlet commented Jan 29, 2020

Issue

The logging is broken and shows this kind of logs when starting the app or running some unit tests.

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Another type of log was mentioned at startup stating "Starting service Pronom[...]"

Context

Introduced in PR #352 on commit ccd5a6c while fixing dependency check issues.

Fix

  • put back log4j slf4j binding dependency in all modules ran or having unit tests
  • tell apache.cxf to use slf4j instead of log4j (was using log4j1 and ignoring log4j2 config)
  • set root logger to warn (since it's overridden on tna logs to INFO or whatever the user asks)

Acceptance tests

on unit tests

  • run mvn install
  • check above logs do not appear anymore

while running droid apps

  • GUI
    just start the GUI
  • CLI
    ./droid.sh -h is enough

@jcharlet jcharlet added this to the 6.5 milestone Jan 29, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Jan 29, 2020
@jcharlet jcharlet added the bug label Jan 29, 2020
@jcharlet jcharlet self-assigned this Jan 29, 2020
@jcharlet jcharlet requested a review from sparkhi January 29, 2020 16:31
@jcharlet jcharlet moved this from In progress to Review in progress in DROID Kanban board 6.5 Jan 30, 2020
DROID Kanban board 6.5 automation moved this from Review in progress to Reviewer approved Jan 30, 2020
@jcharlet jcharlet merged commit e94e3bb into master Jan 30, 2020
DROID Kanban board 6.5 automation moved this from Reviewer approved to Done Jan 30, 2020
@jcharlet jcharlet deleted the fix_logging branch January 30, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants