Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: format version and name was not given anymore in exports #372

Merged
merged 2 commits into from
Jan 31, 2020
Merged

fix: format version and name was not given anymore in exports #372

merged 2 commits into from
Jan 31, 2020

Conversation

jcharlet
Copy link
Contributor

@jcharlet jcharlet commented Jan 31, 2020 •
edited

issue

from @Dclipsham: one thing i picked up on with the build @jeremie gave to me - when exporting the CSV, the format identifier columns were not correct - no PUID, name or version listed. I gotta leave now but can replicate tomorrow if needed
#360

context

introduced on #212 745cc37

solution

put back previous code where we retrieve name and version from jdbc query (rather than constant)

Acceptance test

  • run analysis of a folder on GUI
  • make an export
  • check that version and name columns are now provided in the export

@jcharlet jcharlet added the bug label Jan 31, 2020
@jcharlet jcharlet added this to the 6.5 milestone Jan 31, 2020
@jcharlet jcharlet requested a review from sparkhi January 31, 2020 15:31
@jcharlet jcharlet self-assigned this Jan 31, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Jan 31, 2020
DROID Kanban board 6.5 automation moved this from In progress to Reviewer approved Jan 31, 2020
@jcharlet
Copy link
Contributor Author

export_broken.txt
export_fixed.txt

@jcharlet jcharlet merged commit 157ec56 into master Jan 31, 2020
DROID Kanban board 6.5 automation moved this from Reviewer approved to Done Jan 31, 2020
@jcharlet jcharlet deleted the fix_export branch January 31, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkhi sparkhi sparkhi approved these changes

Assignees

@jcharlet jcharlet

Labels
bug
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcharlet @sparkhi