Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CLI can browse again folders recursively #376

Merged
merged 1 commit into from
Feb 6, 2020
Merged

fix: CLI can browse again folders recursively #376

merged 1 commit into from
Feb 6, 2020

Conversation

jcharlet
Copy link
Contributor

@jcharlet jcharlet commented Feb 3, 2020 •
edited

Issue

Tried using the -R flag to recurse folders ./droid.sh -Nr "/home/saurabh/test-data/warc" -Ns "DROID_SignatureFile_V96.xml" -Wt WARC -R
---- It did not recurse the folders underneath which also had WARC files

fix #363

Context

bug introduced in droid/droid-command-line/src/main/java/uk/gov/nationalarchives/droid/command/action/NoProfileRunCommand.java on commit 0d3cbe2 from #167

Acceptance tests

  • run CLI on folder containing sub folders
    with following arguments (adapt to your workspace)
-R
-Nr
/boot/grub
-Ns
/home/jeremie/.droid6/signature_files/DROID_SignatureFile_V91.xml
-Nc
/home/jeremie/.droid6/container_sigs/container-signature-20170330.xml
  • verify CLI processed sub folders

@jcharlet jcharlet added the bug label Feb 3, 2020
@jcharlet jcharlet added this to the 6.5 milestone Feb 3, 2020
@jcharlet jcharlet self-assigned this Feb 3, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Feb 3, 2020
@jcharlet jcharlet changed the title fix: CLI can browse again folders recursively WIP fix: CLI can browse again folders recursively Feb 3, 2020
@jcharlet jcharlet changed the title WIP fix: CLI can browse again folders recursively fix: CLI can browse again folders recursively Feb 3, 2020
@jcharlet jcharlet requested a review from sparkhi February 3, 2020 16:47
@jcharlet
Copy link
Contributor Author

jcharlet commented Feb 3, 2020

ready to review

@jcharlet jcharlet moved this from In progress to Review in progress in DROID Kanban board 6.5 Feb 3, 2020
This was referenced Feb 3, 2020
Closed
Merged
Closed
DROID Kanban board 6.5 automation moved this from Review in progress to Reviewer approved Feb 6, 2020
@jcharlet jcharlet merged commit c195325 into master Feb 6, 2020
DROID Kanban board 6.5 automation moved this from Reviewer approved to Done Feb 6, 2020
@jcharlet jcharlet deleted the fix_recursive_363 branch February 6, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkhi sparkhi sparkhi approved these changes

Assignees

@jcharlet jcharlet

Labels
bug
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

CLI does not browse recursively
2 participants
@jcharlet @sparkhi