fix: processing of the quiet parameter on CLI #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fix #387
according to the documentation, when set, the quiet parameter should override the consoleLogThreshold JVM parameter, and define the TNA logger to ERROR.
It was not taken into account because the processing of the JVM params happen after the spring context (including log4j) was initialized.
Solution
manual process at the very start of the CLI app: check for --quiet or -q parameter in app arguments, and set the env variable accordingly
Acceptance tests
run the CLI in quiet mode, only csv results and errors should appear