Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix .bat file in bundle without jre #394

Merged
merged 1 commit into from
Mar 6, 2020
Merged

fix .bat file in bundle without jre #394

merged 1 commit into from
Mar 6, 2020

Conversation

jcharlet
Copy link
Contributor

Issue

was using jre file path in both binaries with and without jre.

Solution

Parameterized it

Reproduce

  • mvn package the droid project
  • unzip the 2 binaries in droid/droid-binary/target in separate folders
  • run for each the bat file and verify we can run Droid without error.

@jcharlet jcharlet added the bug label Feb 21, 2020
@jcharlet jcharlet added this to the 6.5 milestone Feb 21, 2020
@jcharlet jcharlet self-assigned this Feb 21, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Feb 21, 2020
@jcharlet jcharlet merged commit 728ab93 into master Mar 6, 2020
DROID Kanban board 6.5 automation moved this from In progress to Done Mar 6, 2020
@jcharlet jcharlet deleted the f_bundle branch March 6, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkhi sparkhi Awaiting requested review from sparkhi

Assignees

@jcharlet jcharlet

Labels
bug
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jcharlet