Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iso prefix in CLI when expanding ISO archives #435

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix: iso prefix in CLI when expanding ISO archives #435

merged 1 commit into from
Mar 27, 2020

Conversation

jcharlet
Copy link
Contributor

Issue

fix #433
prefix in CLI was wrong when expanding ISO archives, showing "zip" instead of "iso"

Acceptance tests

  • Run in CLI the following on a folder including ISO and TAR archives (or any other than TAR - change CLI accordingly)
  • check output, make sure error from Paul is corrected (and we see iso at the beginning of lines mentioning the analysis of first children in ISO archives)
-Nr /home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/ -Ns /home/jeremie/.droid6.5/signature_files/DROID_SignatureFile_V96.xml -At ISO TAR

expected output:

/home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso,fmt/468
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/custom sample.rar,fmt/411
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.7z,fmt/484
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.iso,fmt/468
2020-03-27T10:22:37,449  INFO [main] IsoArchiveContainerIdentifier:103 - Identification request for ISO image ignored due to limited support.
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar,x-fmt/265
tar:/iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar!/Screenshot from 2020-01-22 21-36-16.png,fmt/11
tar:/iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar!/Submission format.xlsx,x-fmt/263
tar:/iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar!/Submission format.csv,Unknown
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.zip,x-fmt/263
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar.bz2,x-fmt/268
iso://home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.iso!/samples.tar.gz,x-fmt/266
/home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.zip,x-fmt/263
/home/jeremie/Documents/drive_TNA/droid/samples/archive-parents/archive-parent.tar.gz,x-fmt/266

@jcharlet jcharlet added the bug label Mar 27, 2020
@jcharlet jcharlet added this to the 6.5 milestone Mar 27, 2020
@jcharlet jcharlet requested a review from sparkhi March 27, 2020 10:28
@jcharlet jcharlet self-assigned this Mar 27, 2020
@jcharlet jcharlet added this to In progress in DROID Kanban board 6.5 via automation Mar 27, 2020
DROID Kanban board 6.5 automation moved this from In progress to Reviewer approved Mar 27, 2020
@jcharlet jcharlet merged commit 300ca8d into master Mar 27, 2020
DROID Kanban board 6.5 automation moved this from Reviewer approved to Done Mar 27, 2020
@jcharlet jcharlet deleted the fix_iso_prefix branch March 27, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparkhi sparkhi sparkhi approved these changes

Assignees

@jcharlet jcharlet

Labels
bug
Projects
No open projects
DROID Kanban board 6.5
  
Done
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

iso archive expanded: wrong prefix in CLI outputs
2 participants
@jcharlet @sparkhi