Merge pull request #64 from digitalBush/feature-empty-pool

feat: add ability to disable pool.

README.md

@@ -34,7 +34,7 @@ const sql = skwell.connect( {
 } );
 
 ```
-
+*NOTE:* Setting `pool:false` will disable pooling entirely.
 
 At this point, you have a client (`sql`) that is ready to be used non-transactionally. A pool of connections is maintained in the background and one will be chosen for you to execute your queries. Queries will resolve with the values or be rejected with an error.
 

spec/integration/emptyPool.spec.js

@@ -0,0 +1,22 @@
+const { config } = testHelpers;
+
+const skwell = require( "src" );
+describe( "No Pooling - Integration", () => {
+	let sql;
+	before( async () => {
+		const emptyPoolConfig = Object.assign( {}, config, { pool: false } );
+		sql = await skwell.connect( emptyPoolConfig );
+	} );
+
+	after( () => {
+		return sql.dispose();
+	} );
+
+	it( "should not reuse the same connection", async () => {
+		const query = "select connection_id from sys.dm_exec_connections where session_id = @@spid";
+
+		const cid1 = await sql.queryValue( query );
+		const cid2 = await sql.queryValue( query );
+		cid1.should.not.equal( cid2 );
+	} );
+} );

spec/integration/reset.spec.js

@@ -13,9 +13,11 @@ describe( "Connection Reset - Integration", () => {
 	} );
 
 	it( "should reuse the same connection between each call", async () => {
-		const spid = await sql.queryValue( "select @@spid" );
-		const spid2 = await sql.queryValue( "select @@spid" );
-		spid.should.equal( spid2 );
+		const query = "select connection_id from sys.dm_exec_connections where session_id = @@spid";
+
+		const cid1 = await sql.queryValue( query );
+		const cid2 = await sql.queryValue( query );
+		cid1.should.equal( cid2 );
 	} );
 
 	it( "should reset connection between calls", async () => {

spec/integration/types.spec.js

@@ -158,7 +158,7 @@ describe( "Types - Integration", () => {
 					( value BIGINT );
 			END` );
 
-		const ids = await sql.query( `SELECT value FROM @ids`, {
+		const ids = await sql.query( "SELECT value FROM @ids", {
 			ids: {
 				type: sql.tvp( "IdTable", {
 					value: sql.bigint

src/EmptyPool.js

@@ -0,0 +1,16 @@
+const EventEmitter = require( "events" );
+class EmptyPool extends EventEmitter {
+
+	constructor( { create, destroy } ) {
+		super();
+
+		this.acquire = create;
+		this.release = destroy;
+	}
+
+	drain() { return Promise.resolve(); }
+	clear() { /* Nothing to do */ }
+
+}
+
+module.exports = EmptyPool;

src/poolFactory.js

@@ -2,6 +2,7 @@ const genericPool = require( "generic-pool" );
 
 const configBuilder = require( "./configBuilder" );
 const connectionFactory = require( "./connectionFactory" );
+const EmptyPool = require( "./EmptyPool" );
 
 function getResourceFactory( client, config ) {
 	return {
@@ -30,5 +31,8 @@ function getResourceFactory( client, config ) {
 
 module.exports = ( client, config ) => {
 	const resourceFactory = getResourceFactory( client, config );
+	if ( config.pool === false ) {
+		return new EmptyPool( resourceFactory );
+	}
 	return genericPool.createPool( resourceFactory, configBuilder.connectionPool( config ) );
 };